-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trio 0.17.0 updates #12
Conversation
This reverts commit 4215a9a.
fix tests. Incomplete but way better than before, so …
update to Trio 0.9.0
I also just noticed there's a commit in |
Closing this because the recent reset to match https://github.com/M-o-a-T/asyncamqp (which is anyio-based) invalidates the trio-interface concerns. |
Fixes #10
Fixes #11
Notes:
tox.ini
(updating the envlist and the pytest command, which seemed to not work at all the way it was, as well as updating the renamedallowlist_externals
option and settingminversion
to ensure the new name is recognized).trio
dep constraint to>=0.15.0
, as I couldn't see any other applicable deprecations/removals since then.import mock
tofrom unittest import mock
, as I don't see how that could have worked before, short of manually installing the externalmock
package.test_connect.py
and one intest_queue.py
).test_consume.py
, wherepytest-trio
claims that the expected error was not raised, but in fact it was. This seems like a bug inpytest-trio
(which has also been updated sincetrio-amqp
), but I'm not sure and didn't feel comfortable making the call on the proper way to fix it.It's very possible that I may have misunderstood the intent in any of these cases - please let me know if there's anything you'd like done differently.