tracking of browser process / waiting for browser close / update start args / couple of example fixes #261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added a couple of changes
First I've added tracking of the browser process's launched
this can be retrieved via get_browser_process()
the idea is to use this to determine when the browser process has closed
so the python side can then close as well at the same time
Next there's a method called wait_browser_close()
this can be used to wait for browser instances to close
Next I've added a update_startargs() method, just to avoid accessing _start_args directly
What I'm doing is just using eel to launch chrome in application mode, but using a flask app as the backend
something like this
So instead of running the inbuilt bottle server, I'm running flask in a thread
(marked as a daemon so that it terminates when the main thread finishes)
then once we get past wait_browser_close() the whole app closes threads and all