Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more information to helpdm embeds. #2056

Closed
wants to merge 6 commits into from
Closed

Add more information to helpdm embeds. #2056

wants to merge 6 commits into from

Conversation

Qwerty-133
Copy link
Contributor

Implements part 1 of #1960

@Qwerty-133 Qwerty-133 marked this pull request as draft January 25, 2022 16:18
MarkKoz
MarkKoz requested changes Jan 26, 2022
View reviewed changes
Copy link
Member

@MarkKoz MarkKoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather see most, if not all the help dm code in the _messages.py file or some new module rather than in the cog's file. The cog already has quite a lot going on, and we should try to avoid making it even harder to read.

@MarkKoz MarkKoz added a: help channels Related to the help channel system t: enhancement Changes or improvements to existing features labels Jan 26, 2022
@Xithrius Xithrius added p: 3 - low Low Priority s: WIP Work In Progress labels Jan 31, 2022
@Xithrius
Copy link
Member

@Qwerty-133 What's your status on this PR?

Thanks!

@Qwerty-133
Copy link
Contributor Author

Hey @Xithrius! I'll be finishing this up soon, thanks for the reminder

@Xithrius
Copy link
Member

@Qwerty-133 Hey, been a while. Thoughts on reviving this PR?

Thanks!

@wookie184
Copy link
Contributor

Since this is quite old and there are a lot of conflicts since this was made before we moved to forum help channels, i'll close this. It probably also needs some more discussion about what parts are still relevant/need changing on the issue before continuing.

@wookie184 wookie184 closed this Jan 3, 2024
@ChrisLovering ChrisLovering deleted the helpdm branch October 31, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkKoz MarkKoz MarkKoz requested changes

Assignees
No one assigned
Labels
a: help channels Related to the help channel system p: 3 - low Low Priority s: WIP Work In Progress t: enhancement Changes or improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Qwerty-133 @Xithrius @wookie184 @MarkKoz