Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not attempt to read response body if the HTTP response code is 204. #200

Closed
wants to merge 1 commit into from
Closed

Do not attempt to read response body if the HTTP response code is 204. #200

wants to merge 1 commit into from

Conversation

ChrisLovering
Copy link
Member

@ChrisLovering ChrisLovering commented Dec 14, 2023 •
edited
Loading

Previously only pydis_core.site_api.APIClient.delete did this.

Changelog:
image

Changed docs:
image
image

@netlify Netlify
Copy link

netlify bot commented Dec 14, 2023 •
edited
Loading

✅ Deploy Preview for bot-core ready!

Name Link
🔨 Latest commit f4427b7
🔍 Latest deploy log https://app.netlify.com/sites/bot-core/deploys/657b3286cb74ec000802fa13
😎 Deploy Preview https://deploy-preview-200--bot-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ChrisLovering ChrisLovering marked this pull request as draft December 14, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shtlrs shtlrs shtlrs approved these changes

@jchristgit jchristgit jchristgit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisLovering @jchristgit @shtlrs