-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make LocaleDataDict Generic #961
base: master
Are you sure you want to change the base?
Make LocaleDataDict Generic #961
Conversation
Codecov Report
@@ Coverage Diff @@
## master #961 +/- ##
==========================================
- Coverage 90.91% 90.90% -0.02%
==========================================
Files 25 25
Lines 4350 4353 +3
==========================================
+ Hits 3955 3957 +2
- Misses 395 396 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
That's a great change – I don't think it messes up any valid downstream workflows. However seeing as that retval was added here 8b7c5e1 in a commit that talks about likely subtag resolving, could you make sure that it doesn't affect that functionality? I think we might need to do |
As far as I can tell, there aren't any locations in the lib that expect the return type of The places that check for locale being It could raise a different exception from the standard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little wary about the LocaleDataDict changes... The numbers changes look alright though, can you break them out into a separate PR?
d1847f8
to
2171b6c
Compare
This reverts commit 47ef03b.
Type annotation improvements:
LocaleDataDict
useTypeVar
s so that the key and value types can be annotated for each instanceLocaleDataDict
LocaleDataDict
Other changes moved to #966