Add django_debug_sql ini option #725
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #725 +/- ##
==========================================
+ Coverage 97.06% 97.93% +0.87%
==========================================
Files 32 33 +1
Lines 2009 1891 -118
Branches 153 150 -3
==========================================
- Hits 1950 1852 -98
+ Misses 43 26 -17
+ Partials 16 13 -3
Continue to review full report at Codecov.
|
This was referenced May 17, 2019
TODO: - [ ] doc - [ ] use a command line option instead? I've thought about having a fixture also, but it would require to set "force_debug_cursor" on the connections then, and it probably not useful; typically you want to use this for a short time only - therefore a command line option might be better suited also (but you can use `-o django_debug_sql = 1`). And on the other hand, it will only show up on failures, and is therefore maybe good to set it in general.
|
I'd really like to see this baked into pytest-django! I hadn't seen this PR, but I'm currently using it through conftest.py like this |
|
This would indeed be very handy. Thanks for the workaround @fopina |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
I've thought about having a fixture also, but it would require to set
"force_debug_cursor" on the connections then, and it probably not
useful; typically you want to use this for a short time only - therefore
a command line option might be better suited also (but you can use
-o django_debug_sql = 1). And on the other hand, it will only show up onfailures, and is therefore maybe good to set it in general.