-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rockstar+RAMSES functionality #238
Closed
AnatoleStorck
wants to merge
18
commits into
pynbody:master
from
AnatoleStorck:AnatoleStorck-rockstarRAMSESupdate
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
368040b
Update pre-commit
cphyc caa87dc
Add possibility to x-link with yt
cphyc 49f23f6
support RAMSES data with rockstar halos
AnatoleStorck c72c993
Make sure indices are handled correctly
0a02ccd
Allow importing properties
bba7094
Attempt to cache parent dataset
cphyc f52d08e
Merge remote-tracking branch 'Pontzen/master' into merging-to-pontzen
AnatoleStorck 599b62d
removed logging/degugging statements
AnatoleStorck 6d8370c
Update add_simulation.py
AnatoleStorck 3e51429
Yield from statfile if it exists
AnatoleStorck 36db469
Merge branch 'master' into AnatoleStorck-rockstarRAMSESupdate
AnatoleStorck fd30444
removed random space
AnatoleStorck 83d4fbc
Apply suggestions from code review
AnatoleStorck c32192a
removed commented out logging
AnatoleStorck 36cf449
removed more commented out logging
AnatoleStorck e6b9bdb
Merge branch 'pynbody:master' into AnatoleStorck-rockstarRAMSESupdate
AnatoleStorck f7102ba
Merge branch 'AnatoleStorck-rockstarRAMSESupdate' of github.com:Anato…
AnatoleStorck 26a6150
Merge branch 'pynbody:master' into AnatoleStorck-rockstarRAMSESupdate
AnatoleStorck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know where this piece of code comes from? It's really hard to make sense out of it and I'm wondering if we could simplify it somehow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the YtRamsesRockstarInputHandler was first created by taking the YtEnzoRockstarInputHandler and adapting it to ramses datasets. This function is taken from there.