Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

インタープリタ起動コマンドの表記ゆれ修正 #222

Merged
merged 1 commit into from
Oct 29, 2023
Merged

インタープリタ起動コマンドの表記ゆれ修正 #222

merged 1 commit into from
Oct 29, 2023
+4 −4

Conversation

soogie
Copy link
Contributor

@soogie soogie commented Oct 29, 2023

チケットへのリンク

このレビューで確認して欲しい点

  • 他の章も確認したうえでpythonに統一する判断をしたがそれでよいか
  • macOS, Linuxはpython3 というコメントは初出1箇所（リスト2.10）のみにしたがそれでよいか

contributorに追加を希望する場合は、以下にチェックを入れてsource/organize/3_contributers.rstに自分の名前を入れた変更をこのPull Requestに加えること

  • contributorに追加を希望する

@ryu22e ryu22e self-requested a review October 29, 2023 03:18
ryu22e
ryu22e approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@ryu22e ryu22e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
（貢献者一覧への名前追記は別PRで行うと本人から伺ったのでこのままマージします）

@ryu22e ryu22e merged commit b4dc557 into pyconjp:master Oct 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryu22e ryu22e ryu22e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soogie @ryu22e