Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor k8s support #330

Merged
merged 7 commits into from
Sep 26, 2023
Merged

Conversation

bobsoppe
Copy link
Contributor

How to test pre-release?

☠️ Feature can be unstable and break your prompt!

fisher install bobsoppe/fish-prompt-pure@improve-k8s-support
set --universal pure_enable_k8s true
set --universal pure_color_k8s_symbol cyan

Specs

New config in conf.d/pure.fish

_pure_set_default pure_color_k8s_symbol pure_color_dark

Documentation

Usage

set --universal pure_enable_k8s true

Changes

  • Added option to color the k8s symbol
  • Added logic to show the k8s prompt when a context has been set
  • Added logic to show the default k8s namespace

Acceptance Checks

  • documentation is up-to-date:
  • feature flag is present in conf.d/pure.fish ;
  • symbol is present in conf.d/pure.fish ;
  • tests are passing (I can help you 🤗 ):
  • customization is available ;
  • feature is implemented.

@bobsoppe bobsoppe changed the title Improve k8s support refactor k8s support Sep 22, 2023
Copy link
Member

@edouard-lopez edouard-lopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Overall LGTM, however, we need some changes to support Fish 3.3.1 and follow the naming convention.
Note: pipeline is in false positive success

functions/_pure_prompt_k8s.fish Outdated Show resolved Hide resolved
conf.d/pure.fish Outdated Show resolved Hide resolved
@bobsoppe
Copy link
Contributor Author

Thank you for the feedback, I have applied your suggestions.

@edouard-lopez edouard-lopez merged commit ee9dd1d into pure-fish:master Sep 26, 2023
6 checks passed
@edouard-lopez
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants