Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/add kubernetes k8s support #323

Merged
merged 18 commits into from
Aug 16, 2023

Conversation

edouard-lopez
Copy link
Member

@edouard-lopez edouard-lopez commented Aug 2, 2023

fixes: #322
related: #291


Specs

Required addition to config

_pure_set_default pure_enable_k8s true
_pure_set_default pure_symbol_k8s "☸️"

Resources

There are several prompts that offer k8s support, we can get inspired by them:

Checks

  • documentation is up-to-date
  • tests have been written
    • feature is tested
    • config are tested
  • feature flag is present
  • customizable prefix is available
  • feature is implemented

Preview (might change)

Currently part of main prompt
image

Warning message when kubectl is missing

pure-k8s-feature.webm

Test pre-release (unstable)

fisher install pure-fish/pure@feat/add-kubernetes-k8s-support-322
set --universal pure_enable_k8s true

@edouard-lopez edouard-lopez force-pushed the feat/add-kubernetes-k8s-support-322 branch 3 times, most recently from 3d156f2 to 190e8dd Compare August 2, 2023 10:32
@edouard-lopez edouard-lopez changed the title docs(release): require to follow semantic versioning feat/add kubernetes k8s support Aug 3, 2023
@edouard-lopez edouard-lopez force-pushed the feat/add-kubernetes-k8s-support-322 branch from 932eac9 to ea6c3bf Compare August 16, 2023 10:02
@edouard-lopez edouard-lopez merged commit 72d84c7 into master Aug 16, 2023
8 checks passed
@edouard-lopez edouard-lopez deleted the feat/add-kubernetes-k8s-support-322 branch August 16, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add kubernetes/k8s support
1 participant