-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Git Includes (Sparse Checkout) #637
base: main
Are you sure you want to change the base?
Conversation
527ef1c
to
204931d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 😍! I added some in-line comments for minor points to check.
Thanks for reviewing! Pushed a couple updates and tweaks based on your suggestions. Let me know if you'd prefer me to clean up the commits or rebase or anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good. I think you can squash your commits if you feel this is ready.
707b0fb
to
5674413
Compare
Awesome. I think I've got them squashed into logical groupings at least (feature, docs, tests), but let me know if you want it squashed further. Thanks again for looking this over. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I would merge that if I was not the only reviewer, so let's wait for more review/feedback.
Thanks!
Summary
Enable git sparse-checkout when
:includes
are definedAdditional Context
The goal here is to enable sparse-checkout on a git repository when
:includes
are defined. This allows you to only include certain files or directories as needed, or when working in a monorepo for example.I was able to test this out locally and it seems to function as I'd expect, only checking out specific files or directories on multiple versions of git, and triggers updates (checkout) if the list of includes changes. I'm not terribly familiar with rspec tests, but I did my best to add a couple unit tests to verify the functionality as well. Let me know if there's anything missing. Thank you!
Related Issues (if any)
Resolves #636
Checklist
puppet apply
)