Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PA-5586]: Add debian-12-x86_64 to the puppet agent module task acceptance #706

Merged
merged 2 commits into from
Mar 6, 2024
Merged

[PA-5586]: Add debian-12-x86_64 to the puppet agent module task acceptance #706

merged 2 commits into from
Mar 6, 2024

Conversation

span786
Copy link
Contributor

@span786 span786 commented Mar 4, 2024

Added debian-12 to the puppet agent module task acceptance

@span786 span786 requested review from bastelfreak and a team as code owners March 4, 2024 15:45
kenyon
kenyon approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing, since these are regexps, the dot can match any character, which shouldn't cause an unexpected match, but I always like to escape characters that should be literal instead of regexp metacharacters. You could also use Regexp.escape here instead.

task_spec/spec/acceptance/init_spec.rb Outdated Show resolved Hide resolved
@span786 span786 force-pushed the PA-5586-add-debian-12-x86-64-to-the-puppet-agent-module-task-acceptance branch from 1b3a1f5 to 84a53a9 Compare March 5, 2024 07:20
@span786 span786 requested a review from kenyon March 5, 2024 07:22
@span786 span786 requested review from skyamgarp and kenyon March 6, 2024 05:26
@span786
Copy link
Contributor Author

span786 commented Mar 6, 2024

@bastelfreak can you please review this PR ?
It is not allowing to merge without code owner approval.

@span786 span786 merged commit 25012c4 into puppetlabs:main Mar 6, 2024
17 checks passed
@mhashizume mhashizume added the maintenance Maintenance chores are typically excluded from changelogs label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

@kenyon kenyon kenyon approved these changes

@skyamgarp skyamgarp Awaiting requested review from skyamgarp

Assignees
No one assigned
Labels
maintenance Maintenance chores are typically excluded from changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@span786 @kenyon @bastelfreak @skyamgarp @mhashizume