Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) Remove .project file #678

Merged
merged 1 commit into from
Oct 30, 2023
Merged

(maint) Remove .project file #678

merged 1 commit into from
Oct 30, 2023

Conversation

mhashizume
Copy link
Contributor

.project files were once used for the long-defunct Geppetto. This commit removes an old .project file in the root of this project.

@mhashizume
(maint) Remove .project file
df35513 
.project files were once used for the long-defunct Geppetto. This commit
removes an old .project file in the root of this project.
@mhashizume mhashizume added the maintenance Maintenance chores are typically excluded from changelogs label Oct 30, 2023
@mhashizume mhashizume requested review from bastelfreak and a team as code owners October 30, 2023 21:37
joshcooper
joshcooper approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are some references to .gitignore and .pdkignore though I assume those are part of the module sync business and can be left as-is

@mhashizume mhashizume merged commit c9fe71d into puppetlabs:main Oct 30, 2023
17 checks passed
@mhashizume mhashizume deleted the maint/main/geppetto-removal branch October 30, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcooper joshcooper joshcooper approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance chores are typically excluded from changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhashizume @bastelfreak @joshcooper