Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep sections when they become empty #536

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Keep sections when they become empty #536

wants to merge 2 commits into from
+11 −82

Commits on Jun 6, 2024

  1. Revert "(CAT-1646) - Remove section if its not have any settings" 

    PR #532 introduced 4ebe030 which breaks
backwards compatibility and is part of a patch release, as reported here:
#532 (comment)

This reverts commit 4ebe030.

This will allow us to do a new patch release that fix the unexpected
backwards incompatible change, and leave the room to implement this as
part of a next major version of the module.
    @smortex @Ramesh7
    smortex authored and Ramesh7 committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    4228447 View commit details
    Browse the repository at this point in the history

  2. Keep sections when they become empty 

    When the last setting of a section was removed, the whole section was
removed unless it contained white space of comments.  In #532, this was
changed to also remove sections that only contained space (blank lines),
but it caused regressions and was reverted in #535.

For consistency, we completely suppress the auto-removal of "empty"
sections: removing the last setting of a section will not remove this
section anymore, just like what happens for sections with only blank
lines and comments.
    @smortex @Ramesh7
    smortex authored and Ramesh7 committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    5635e76 View commit details
    Browse the repository at this point in the history