-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix the vhost security configuration #2531
base: main
Are you sure you want to change the base?
Conversation
3601886
to
a668633
Compare
Can we launch the re-failed tests ? seems a problem on the CI side ? |
The modified variable was never passed to the template, resulting in a bad configuration of the vhost security if secrule were removed. Signed-off-by: Julien Godin <[email protected]>
Seems to also cause a problem if the modsecure_disable_ids parameter is an Array, as the Hash Array built never gets passed to the "epp" processing |
@stevegreengvl I dont get it , |
@JGodin-C2C we have this in our PUppet code Up to Version 11.1.0 of the Module all was fine in the generated vhost Config file, from Version 12.0 the Block below is missing from the generated file <LocationMatch .*> But I think this fix will resolve the issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is correct, but it would be nice to have a test for this.
The modified variable was never passed to the template, resulting in a bad configuration of the vhost security if secrule were removed.