Update build and package names #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mjeffryes
commented
Jun 19, 2024
mjeffryes
commented
- Migrate this provider to the pulumi namespace
- Update build system with ci-mgmt (including enabling respectSchemaVersion and PyPackage for codegen)
- Upgrade tfbridge and pu/pu
- regenerate SDKs
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
iwahbe
approved these changes
Jun 20, 2024
provider/resources.go
Outdated
| @@ -25,7 +25,7 @@ const ( | |||
| serviceMod = "service" | |||
| ) | |||
|
|
|||
| func preConfigureCallback(vars resource.PropertyMap, c shim.ResourceConfig) error { | |||
| func preConfigureCallback(_ resource.PropertyMap, _ shim.ResourceConfig) error { | |||
There was a problem hiding this comment.
We can just delete this function (not passing it to tfbridge.Info).
.ci-mgmt.yaml
Outdated
| provider: harness | ||
| major-version: 0 | ||
| makeTemplate: bridged | ||
| generate-nightly-test-workflow: true |
There was a problem hiding this comment.
Do we need the nightly workflow for this provider? We normally save that for tier 1 providers.
|
We don't maintain a CHANGELOG anymore. We just use GH's releases. You can just delete CHANGELOG.md and that will make the "Update Changelog" bot happy. |
iwahbe
added a commit
to pulumi/ci-mgmt
that referenced
this pull request
Jun 24, 2024
with [Update build and package names · pulumi-harness/59](pulumi/pulumi-harness#59), the harness provider should be ready to add to the fleet. --------- Co-authored-by: Ian Wahbe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.