Adding in support for a "No Project" setting for gcp:project
#2653
Conversation
rshade
force-pushed
the
rshade/support-no-gcp_project
branch
from
2c05a7f
to
4e1d52b
Compare
rshade
changed the title
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
There was a problem hiding this comment.
I like DisableGlobalProjectWarning much more then project: "No Project".
Can you please link the issue you are addressing and explain your fix in the PR body. If users see that the underlying issue is fixed, they should understand at minimum how to apply the fix for themselves.
Absolutely, will do. |
rshade
force-pushed
the
rshade/support-no-gcp_project
branch
4 times, most recently
from
0416cd6
to
642c6b8
Compare
iwahbe
changed the title
gcp:project
rshade
force-pushed
the
rshade/support-no-gcp_project
branch
from
642c6b8
to
5f715d4
Compare
Co-authored-by: Ian Wahbe <[email protected]>
rshade
force-pushed
the
rshade/support-no-gcp_project
branch
from
1313c75
to
152540b
Compare
rshade
force-pushed
the
rshade/support-no-gcp_project
branch
from
152540b
to
647c9ff
Compare
| @@ -169,6 +169,10 @@ const ( | |||
| gcpWorkstations = "Workstations" // Workstations | |||
| ) | |||
|
|
|||
| // When `gcp:project` is set to noProjectMarker, we don't warn that a global project is missing | |||
| // and we don't try to validate the project. | |||
| const noProjectMarker = "DisableGlobalProjectWarning" | |||
There was a problem hiding this comment.
I am a bit late to the party here but should we perhaps add a new config to disable the warning instead? That seems like a nicer UX for users than a magic string in place of the project config and a bit easier to discover.
e.g.
So instead of:
gcp.Provider(project="DisableGlobalProjectWarning")users would use
gcp.Provider(disable_global_project_warning=true)You can define that here:
pulumi-gcp/provider/resources.go
Line 534 in a30bcc5
We have an existing config we've added to disable another similar check.
There was a problem hiding this comment.
The benefit of this is that it would automatically get added to our docs etc. It would also be discoverable as a property on the ProviderArgs.
It might also work better with other things in the provider as I do not know all the places where the project is used - setting it to an invalid string might interact in odd ways with other things.
There was a problem hiding this comment.
@rshade LMK what you think, also happy to help with this.
There was a problem hiding this comment.
@iwahbe @guineveresaenger thoughts? I am good any way we do it.
There was a problem hiding this comment.
This is definitely better.
gcp.Provider(disable_global_project_warning=true)
When I saw DisableGlobalProjectWarning I initially assumed that ☝️ is what was meant (which I then promptly forgot to right down when I saw the code
There was a problem hiding this comment.
excellent thank you @VenelinMartinov @iwahbe I will get that put in on Monday.
fixes #1168