-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#203): RunException access modifier set to public. Docs updated #364
feat(#203): RunException access modifier set to public. Docs updated #364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I'll let someone with more context approve and merge this, but do have a small suggestion for a changelog improvement (see also https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md#changelog-messages for how we write our changelog messages)
Co-authored-by: Thomas Gummerer <[email protected]>
@tgummerer when do You think someone will get the chance to look at this? :) |
Hi there @mmisztal1980 thanks a lot for the contribution 🙏 we discussed this with the team and we thought it made sense to make the exception public. |
@Zaid-Ajaj awesome! |
@mmisztal1980 Not planned at the moment, but we publish dev sdks from commits merged into main so you will be able to use the an alpha package containing your changes |
This PR has been shipped in release v3.69.0. |
As per discussion in #203 . This is a simple improvement in order to make the exception assertable by testing frameworks such as
FluentAssertions
using:This will significantly improve testing scenarios where exceptions are being thrown, as everything gets wrapped in an internal
Pulumi.RunException
while testing: