WIP: allow dotnet to emit better errors for component construct #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new InputPropertiesError that allows users to return more error details from a component construct.
tgummerer
commented
Oct 3, 2024
|
|
||
| // var details = Google.Protobuf.WellKnownTypes.Any.Pack(status); | ||
| var metadata = new Metadata(); | ||
| metadata.Add("grpc-status-details-bin", Google.Protobuf.MessageExtensions.ToByteArray(status)); |
There was a problem hiding this comment.
This is how I thought the status details need to be added to the exception, but for some reason it doesn't seem to add the details.
E.g. here (this one is slightly different since it packs it into an Any type bofere or here it seems to be done in the same way, but neither of those ways seem to make it work for me. Not sure if I'm doing something wrong somewhere here 🤔
There was a problem hiding this comment.
Note for myself: https://github.com/grpc/grpc-dotnet/tree/master/src/Grpc.StatusProto#server-side seems useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new InputPropertiesError that allows users to return more error details from a component construct.