Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toward schema-ifying import ids in the metadata #1662

Closed
wants to merge 2 commits into from
Closed

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Aug 12, 2024

No description provided.

Copy link
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.99%. Comparing base (f34f0b1) to head (67d532a).
Report is 88 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/schema/gen.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1662      +/-   ##
==========================================
+ Coverage   41.94%   41.99%   +0.04%     
==========================================
  Files          35       35              
  Lines        4706     4713       +7     
==========================================
+ Hits         1974     1979       +5     
- Misses       2532     2533       +1     
- Partials      200      201       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t0yv0
Copy link
Member Author

t0yv0 commented Nov 26, 2024

Closing in favor of #1861

@t0yv0 t0yv0 closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant