Fix AWS OIDC TS example #1719
Merged
Fix AWS OIDC TS example #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not possible to have a single stack which handles both the use case of creating a new OIDC provider and also adding an audience if none exists. This change removes the conditional creation of an OIDC provider and assumes none exists.
|
🍹 The Update for pulumi/k8s-ci-cluster/fdb201748d90389a09c344ae2fa45e94322adf06-284 was successful. Resource Changes Name Type Operation
+ k8s-ci-cluster-fdb201748d90389a09c344ae2fa45e94322adf06-284 pulumi:pulumi:Stack create
+ multicloud pulumi-kubernetes:ci:GkeCluster create
+ password random:index/randomPassword:RandomPassword create
+ ephemeral-ci-cluster gcp:container/cluster:Cluster create
+ primary-node-pool gcp:container/nodePool:NodePool create
+ gke pulumi:providers:kubernetes create
|
|
🍹 The Destroy for pulumi/k8s-ci-cluster/fdb201748d90389a09c344ae2fa45e94322adf06-284 was successful. Resource Changes Name Type Operation
- gke pulumi:providers:kubernetes delete
- primary-node-pool gcp:container/nodePool:NodePool delete
- ephemeral-ci-cluster gcp:container/cluster:Cluster delete
- multicloud pulumi-kubernetes:ci:GkeCluster delete
- password random:index/randomPassword:RandomPassword delete
- k8s-ci-cluster-fdb201748d90389a09c344ae2fa45e94322adf06-284 pulumi:pulumi:Stack delete
|
pierskarsenbarg
approved these changes
Nov 2, 2024
pierskarsenbarg
requested changes
Nov 2, 2024
|
🍹 The Update for pulumi/k8s-ci-cluster/692fcd077b28ae64c4589969d982c6f195733c31-289 was successful. Resource Changes Name Type Operation
+ primary-node-pool gcp:container/nodePool:NodePool create
+ gke pulumi:providers:kubernetes create
+ k8s-ci-cluster-692fcd077b28ae64c4589969d982c6f195733c31-289 pulumi:pulumi:Stack create
+ multicloud pulumi-kubernetes:ci:GkeCluster create
+ password random:index/randomPassword:RandomPassword create
+ ephemeral-ci-cluster gcp:container/cluster:Cluster create
|
pierskarsenbarg
approved these changes
Nov 4, 2024
|
🍹 The Destroy for pulumi/k8s-ci-cluster/692fcd077b28ae64c4589969d982c6f195733c31-289 was successful. Resource Changes Name Type Operation
- k8s-ci-cluster-692fcd077b28ae64c4589969d982c6f195733c31-289 pulumi:pulumi:Stack delete
- gke pulumi:providers:kubernetes delete
- primary-node-pool gcp:container/nodePool:NodePool delete
- ephemeral-ci-cluster gcp:container/cluster:Cluster delete
- multicloud pulumi-kubernetes:ci:GkeCluster delete
- password random:index/randomPassword:RandomPassword delete
|
|
Looks good. Thanks for this! Would love to see an update to the README that explains this limitation. |
|
Merging for @jkodroff per request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not possible to have a single stack which handles both the use case of creating a new OIDC provider and also adding an audience if none exists. This change removes the conditional creation of an OIDC provider and assumes none exists.