Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FotMob] Get correct team match stats using 'opponent_stats' parameter #541

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

marcjbaron
Copy link
Contributor

@marcjbaron marcjbaron commented Apr 13, 2024

This fixes the issue brought up in #528 where the opponent_stats=True parameter setting returned only the opponent stats, but incorrectly labelled as the requested team's stats. When opponent_stats=True, the correctly labelled match stats for both teams should now be returned.

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.66%. Comparing base (69fb0de) to head (e75273a).
Report is 165 commits behind head on master.

Files with missing lines Patch % Lines
soccerdata/fotmob.py 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   59.33%   63.66%   +4.32%     
==========================================
  Files          11       12       +1     
  Lines        1633     1910     +277     
  Branches      336      386      +50     
==========================================
+ Hits          969     1216     +247     
- Misses        610      629      +19     
- Partials       54       65      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@probberechts probberechts added bug Something isn't working FotMob Issue or pull request related to the FotMob scraper labels Apr 13, 2024
@probberechts probberechts changed the title [FotMob]: Get correct team match stats using 'opponent_stats' parameter [FotMob] Get correct team match stats using 'opponent_stats' parameter Apr 18, 2024
@probberechts probberechts merged commit db65c92 into probberechts:master Apr 18, 2024
10 of 11 checks passed
@marcjbaron marcjbaron deleted the fotmob-iss-528 branch April 18, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FotMob Issue or pull request related to the FotMob scraper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants