-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(psl): GA fullTextIndex
for every supported provider: mysql
, mongodb
#5052
Conversation
WASM Query Engine file Size
|
CodSpeed Performance ReportMerging #5052 will not alter performanceComparing Summary
|
30e5ba9
to
a2d615e
Compare
…iew_flag_should_not_touch_fts_indexes" suite
…nes into feat/ga-fullTextIndex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, one comment/question and a few missing snapshot updates that are currently failing on CI, and we're good to merge.
} | ||
|
||
impl Client { | ||
pub async fn connect(connection_str: &str, preview_features: BitFlags<PreviewFeature>) -> ConnectorResult<Client> { | ||
pub async fn connect(connection_str: &str, _preview_features: BitFlags<PreviewFeature>) -> ConnectorResult<Client> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove the parameter as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend to leave it here. Both the mongodb-schema-connector
and the sql-schema-connector
rely on preview features, and we'll likely need this again in the future. Removing this preview_features
parameter (and its propagated calls) to add it again in the future just adds noise, imho.
All snapshots pass since f413ba4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
This PR:
fullTextIndex
andfullTextSearch
forprovider = "mysql"
#5031fullTextIndex
previewFeatures = ["fullTextIndex"]
inschema.prisma
now results in a validation warning:This PR implies that introspection of existing
@fullText
indexes works.For example, with MongoDB:
Let
$TEST_MONGO_URI
be"mongodb://localhost:27018/tests"
Let's first run
prisma db push
on the following schema, which we call./prisma/schema.prisma
:Let's delete the
model User
:Now, we introspect the existing database. Let's run
prisma db pull --url $TEST_MONGO_URI
, which yields the following result:As you can see, the full-text index on the
name
field is preserved as@@fulltext([name])