Skip to content

Commit

Permalink
fix: resolve compile errors in driver-adapters
Browse files Browse the repository at this point in the history
Signed-off-by: Lucian Buzzo <[email protected]>
  • Loading branch information
LucianBuzzo committed Oct 30, 2023
1 parent adb2a13 commit a8af640
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 10 deletions.
4 changes: 2 additions & 2 deletions quaint/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ choice.

```sh
> cargo build --features all
```
```

### Testing

Expand Down Expand Up @@ -70,7 +70,7 @@ This requires the rust nightly channel:
> cargo rustdoc --all-features
```

Documentation index would be created at `$CARGO_TARGET_DIR/doc/quaint/index.html`
Documentation index would be created at `$CARGO_TARGET_DIR/doc/quaint/index.html`.

## Security

Expand Down
15 changes: 12 additions & 3 deletions query-engine/driver-adapters/src/queryable.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ use crate::{
proxy::{CommonProxy, DriverProxy, Query},
};
use async_trait::async_trait;
use futures::lock::Mutex;
use napi::JsObject;
use psl::datamodel_connector::Flavour;
use quaint::{
Expand All @@ -12,6 +13,7 @@ use quaint::{
visitor::{self, Visitor},
Value,
};
use std::sync::Arc;
use tracing::{info_span, Instrument};

/// A JsQueryable adapts a Proxy to implement quaint's Queryable interface. It has the
Expand Down Expand Up @@ -182,6 +184,7 @@ impl JsBaseQueryable {
pub struct JsQueryable {
inner: JsBaseQueryable,
driver_proxy: DriverProxy,
pub transaction_depth: Arc<Mutex<i32>>,
}

impl std::fmt::Display for JsQueryable {
Expand Down Expand Up @@ -259,14 +262,19 @@ impl TransactionCapable for JsQueryable {
}
}

let begin_stmt = tx.begin_statement();
let mut depth_guard = self.transaction_depth.lock().await;
*depth_guard += 1;

let st_depth = *depth_guard;

let begin_stmt = tx.begin_statement(st_depth).await;

let tx_opts = tx.options();
if tx_opts.use_phantom_query {
let begin_stmt = JsBaseQueryable::phantom_query_message(begin_stmt);
let begin_stmt = JsBaseQueryable::phantom_query_message(&begin_stmt);
tx.raw_phantom_cmd(begin_stmt.as_str()).await?;
} else {
tx.raw_cmd(begin_stmt).await?;
tx.raw_cmd(&begin_stmt).await?;
}

if !isolation_first {
Expand All @@ -288,5 +296,6 @@ pub fn from_napi(driver: JsObject) -> JsQueryable {
JsQueryable {
inner: JsBaseQueryable::new(common),
driver_proxy,
transaction_depth: Arc::new(futures::lock::Mutex::new(0)),
}
}
29 changes: 24 additions & 5 deletions query-engine/driver-adapters/src/transaction.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
use async_trait::async_trait;
use futures::lock::Mutex;
use metrics::{decrement_gauge, increment_gauge};
use napi::{bindgen_prelude::FromNapiValue, JsObject};
use quaint::{
connector::{IsolationLevel, Transaction as QuaintTransaction},
prelude::{Query as QuaintQuery, Queryable, ResultSet},
Value,
};
use std::sync::Arc;

use crate::{
proxy::{CommonProxy, TransactionOptions, TransactionProxy},
Expand All @@ -18,13 +20,22 @@ use crate::{
pub(crate) struct JsTransaction {
tx_proxy: TransactionProxy,
inner: JsBaseQueryable,
pub depth: Arc<Mutex<i32>>,
pub commit_stmt: String,
pub rollback_stmt: String,
}

impl JsTransaction {
pub(crate) fn new(inner: JsBaseQueryable, tx_proxy: TransactionProxy) -> Self {
increment_gauge!("prisma_client_queries_active", 1.0);

Self { inner, tx_proxy }
Self {
inner,
tx_proxy,
commit_stmt: "COMMIT".to_string(),
rollback_stmt: "ROLLBACK".to_string(),
depth: Arc::new(futures::lock::Mutex::new(0)),
}
}

pub fn options(&self) -> &TransactionOptions {
Expand All @@ -39,10 +50,11 @@ impl JsTransaction {

#[async_trait]
impl QuaintTransaction for JsTransaction {
async fn commit(&self) -> quaint::Result<()> {
async fn commit(&mut self) -> quaint::Result<()> {
decrement_gauge!("prisma_client_queries_active", 1.0);

let commit_stmt = "COMMIT";
let mut depth_guard = self.depth.lock().await;
let commit_stmt = &self.commit_stmt;

if self.options().use_phantom_query {
let commit_stmt = JsBaseQueryable::phantom_query_message(commit_stmt);
Expand All @@ -51,13 +63,17 @@ impl QuaintTransaction for JsTransaction {
self.inner.raw_cmd(commit_stmt).await?;
}

// Modify the depth value through the MutexGuard
*depth_guard -= 1;

self.tx_proxy.commit().await
}

async fn rollback(&self) -> quaint::Result<()> {
async fn rollback(&mut self) -> quaint::Result<()> {
decrement_gauge!("prisma_client_queries_active", 1.0);

let rollback_stmt = "ROLLBACK";
let mut depth_guard = self.depth.lock().await;
let rollback_stmt = &self.rollback_stmt;

if self.options().use_phantom_query {
let rollback_stmt = JsBaseQueryable::phantom_query_message(rollback_stmt);
Expand All @@ -66,6 +82,9 @@ impl QuaintTransaction for JsTransaction {
self.inner.raw_cmd(rollback_stmt).await?;
}

// Modify the depth value through the MutexGuard
*depth_guard -= 1;

self.tx_proxy.rollback().await
}

Expand Down

0 comments on commit a8af640

Please sign in to comment.