Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AutoComplete): resolve iconPosition props warning #7447

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix(AutoComplete): resolve iconPosition props warning #7447

wants to merge 6 commits into from

Conversation

KumJungMin
Copy link
Contributor

@KumJungMin KumJungMin commented Nov 23, 2024 •
edited
Loading

Defect Fixes


How to Resolve?

  • <AutoComplete /> has two issue
    • (1) iconPosition props warning
    • (2) iconPostion is not working

issue(1): iconPosition props warning

  • when using <IconField /> and set iconPosition, the iconPosition props warning emeraged in<AutoComplete />.
  • for fix this warning, I added IconPosition in defaultProps of AutoComplete component.

issue(2): iconPostion is not working

  • the iconPosition is working in <InputText />, but not working in <AutoComplete/>.
  • because, the icon-field style is not applied in p-autocomplete
  • for fix this issue, I updated 'primereact-sass-theme' theme(PR link)
before after
스크린샷 2024-11-23 오후 10 30 50 스크린샷 2024-11-23 오후 10 29 54

@vercel Vercel
Copy link

vercel bot commented Nov 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 1:56pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 1:56pm

@KumJungMin KumJungMin mentioned this pull request Nov 23, 2024
Open
@melloware melloware added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mertsincan mertsincan

Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning: React does not recognize the iconPosition prop on a DOM element. (v10.8.3)
3 participants
@KumJungMin @melloware @mertsincan