[PAPAY-1395]: Explicitely shutdown the tracer provider #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enerdgumen
changed the title
enerdgumen
force-pushed
the
PAPAY-1395/task/tokio-error-on-shutdown
branch
from
94760c1
to
d8e950c
Compare
|
|
||
| let mut tracer_provider = TRACER_PROVIDER | ||
| .lock() | ||
| .expect("OpenTelemetry tracer provider mutex poisoned"); |
There was a problem hiding this comment.
What about gracefully handle the poison error recovering the old state?
There was a problem hiding this comment.
It can be poisoned if another thread panicked while it has the mutex locked. But this lock is used only 2 times, at startup and at shutdown.
At startup should not be possible to have a poisoned lock, because noone kept the lock before. At shutdown, it can be poisoned only if the startup panicked (precisely, if mem::replace(&mut *tracer_provider, Some(new_provider)) panicked). But in this case shutdown_tracer_provider will not be called.
So, this seems a good case to use expect, like done by opentelemetry::global::set_tracer_provider...
|
|
||
| let tracer_provider = TRACER_PROVIDER | ||
| .lock() | ||
| .expect("OpenTelemetry tracer provider mutex poisoned") |
cottinisimone
previously approved these changes
Sep 12, 2024
cottinisimone
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/PAPAY-1395
After upgrading this library in our application, we observed the following errors logged after every execution of a scheduled tasks:
This is related to open-telemetry/opentelemetry-rust#1961.
It appears that we should explicitely shutdown the tracer provider, otherwise it doesn't flush all the data when the application terminates. Additionally, the process remains active and the Tokio' runtime complains.