Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COART-181]: Check Gracefully termination in all our applications #208

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[COART-181]: Check Gracefully termination in all our applications #208

wants to merge 6 commits into from

Conversation

frnmjn
Copy link

@frnmjn frnmjn commented Nov 27, 2024 •
edited
Loading

@frnmjn frnmjn force-pushed the COART-181/feature/check-gracefully-termination-in-all-our-applications branch 3 times, most recently from fe5bcf8 to addd178 Compare November 27, 2024 14:19
@frnmjn frnmjn force-pushed the COART-181/feature/check-gracefully-termination-in-all-our-applications branch from addd178 to 98a0c1d Compare November 28, 2024 08:29
@frnmjn frnmjn requested a review from mbusi November 28, 2024 10:11
@frnmjn frnmjn marked this pull request as ready for review November 28, 2024 10:11
@frnmjn frnmjn requested a review from a team as a code owner November 28, 2024 10:11
@frnmjn frnmjn requested a review from a team November 28, 2024 10:20
cpiemontese
cpiemontese reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@cpiemontese cpiemontese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit unclear on the logic

lib/amqp/gen/consumer.ex Outdated Show resolved Hide resolved
lib/amqp/gen/consumer.ex Outdated Show resolved Hide resolved
lib/amqp/gen/consumer.ex Outdated Show resolved Hide resolved
lib/amqp/no_signal_handler.ex Outdated Show resolved Hide resolved
@Johnabell Johnabell force-pushed the COART-181/feature/check-gracefully-termination-in-all-our-applications branch from 8462514 to a265ffb Compare November 28, 2024 12:44
cpiemontese
cpiemontese approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@cpiemontese cpiemontese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes more sense now, basically if the SignalHandler changes state, then processing may transition to draining and eventually stopping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpiemontese cpiemontese cpiemontese approved these changes

@mbusi mbusi Awaiting requested review from mbusi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frnmjn @cpiemontese @Johnabell