Nov 2024

[SethBarberee]

The great renaming of move/orb actions that haven't been documented yet. Still a few more orb funcs in 807CD9C that I would like to finish before marking this PR ready.

[SethBarberee]

HandleTrawlOrbAction is a little too much for me with the huge stack it has so left the WIP scratch and matched the rest of the orb funcs. With that, this PR is ready for review.

[AnonymousRandomPerson]

Perhaps the "Basic" isn't needed. SleepMoveAction by itself conveys the same meaning of being a shared move action between similar sleep moves.

[Kermalis]

If this is referring to rest etc, then Sleep is fine. If it's referring to forcing sleep (like hypnosis), then I suggest "CastSleep".
Same for "CastFreeze" and "CastBurn" etc if that's the situation

[SethBarberee]

It doesn't "force" the status conditions. It still has to roll the chance for a status condition. For example,

bool8 BasicFireMoveAction(Entity *pokemon, Entity *target, Move *move, u32 param_4)
{
  bool8 flag;

  flag = FALSE;
  SendThawedMessage(pokemon, target);
  if (HandleDamagingMove(pokemon,target,move,0x100,param_4) != 0) {
    flag = TRUE;
    if(sub_805727C(pokemon, target, gUnknown_80F4DBA))
    {
        BurnedStatusTarget(pokemon, target, 0, FALSE);
    }
  }
  return flag;
}

[AnonymousRandomPerson]

Some merge conflicts were introduced with #256 merging.

[AnonymousRandomPerson]

@SethBarberee FYI, there are some unresolved comments here that I'm waiting on before approving.

[SethBarberee]

Was on vacation and just got back. Will try to address them in next day or two.