Match some register nonmatchings #247
Conversation
| playerStruct->isTeamLeader = FALSE; | ||
| pokeStruct2->isTeamLeader = TRUE; | ||
| newLeader->isTeamLeader = TRUE; | ||
| nullsub_104(); |
There was a problem hiding this comment.
It'd be cool to make a comment at nullsub_104 stating it's called when the team leader is changed by the player. Eventually when we are at documentation, it'll be cool to see what all the nullsubs were used for (probably printing or breakpoints)
There was a problem hiding this comment.
Would be cool to see if the nullsubs are actually used in JP or Blue versions.
|
|
||
| ALIGNED(4) const char gMeetNinetalesText[] = "Meet Ninetales."; | ||
| ALIGNED(4) const char gAvoidCaptureText[] = "Avoid capture."; | ||
| ALIGNED(4) const char gFinalScenarioText[] = _("Defeat the final Pokémon."); | ||
|
|
||
| // Needed to match | ||
| static inline s16 Self(s16 a) |
There was a problem hiding this comment.
This smells similar to the SpeciesId() inline but instead it's for maze ids
There was a problem hiding this comment.
Yeah, it makes me wonder if SpeciesId should actually exist and there's some unholy InlineCastToS16 used instead
There was a problem hiding this comment.
Nah I think it is definitely a SpeciesId but there also happen to be 2 other times they do that kind of conversion (like maze/friendarea/item/move or something). We'll keep finding these weird casts
There was a problem hiding this comment.
True, but there are issues all around the codebase with s16 arguments which don't match. So unless they had conversion used for everything, it's possible they performed some weird inline cast for all s16.
Though some of them are unknown arguments, so maybe they're indeed just species/moves/items/etc.
No description provided.