-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: new variant resolving / rendering #1122
Open
wolfv
wants to merge
20
commits into
prefix-dev:main
Choose a base branch
from
wolfv:new-variant-resolve
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+772
−595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: missing in this PR are updated handling of |
10 tasks
wolfv
force-pushed
the
new-variant-resolve
branch
from
November 6, 2024 18:22
ac98f93
to
525c6e4
Compare
wolfv
force-pushed
the
new-variant-resolve
branch
from
November 14, 2024 18:25
855bd54
to
2fa80fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to separate things better into "stage 1" and "stage 2" rendering.
Stage 1:
Get all used variables from Jinja and conditional expressions and then render these out for all combinations that are found based on the variant config. This already creates a number of different combinations.
Stage 2:
From the rendered recipes (no more Jinja, conditionals) we need to get all the
requirements
at build/link time and create additional variants.Stage 3:
Topologically sort and de-duplicate outputs (with multiple outputs, these renders might create duplicate outputs, for example if you have a C library and multiple variants for Python bindings).
Note to self:
We need to make sure that we keep this logic from main: