Update CHANGELOG and bump version for release #1319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pointlessone
reviewed
Nov 8, 2023
| @@ -1,5 +1,5 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module Prawn | |||
| VERSION = '2.4.0' | |||
| VERSION = '2.5.0' | |||
There was a problem hiding this comment.
I understand the sentiment but generally this is not done in a PR. I have not decided yet on the version that's going to be released.
There was a problem hiding this comment.
Right makes sense. I put my reasoning there. #1195 (comment)
| ### Look for glyph in correct font | ||
|
|
||
| Take the font style into account when looking for a glyph and fallback fonts are enabled. | ||
|
|
||
| (Dan Allen, [#1147](https://github.com/prawnpdf/prawn/issues/1147)) | ||
|
|
||
| ### Raise an exception on invalid valign value | ||
|
|
||
| (Masakinpo) |
There was a problem hiding this comment.
Don't we have PRs associated with these changes? I might've been cheeky and push to master once ina while but most of the contributions probably had a PR opened first.
There was a problem hiding this comment.
the way things was merged, this information is really hard to track. I'm not going to spend the time tracking down this past 3 years
|
@mathieujobin Thank you for your effort but I did it myself in the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.