Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1668] Dark Mode Audit - Selectable Card #3953

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Lsimmons98
Copy link

@Lsimmons98 Lsimmons98 commented Nov 26, 2024

What does this PR do? A clear and concise description with your runway ticket url.

Updates to dark mode styling based on audit for the Select-able Card component.

PLAY-1668

Screenshots: Screenshots to visualize your addition/change
Screenshot 2024-11-26 at 2 19 39 PM

Screenshot 2024-11-26 at 2 20 47 PM

How to test? Steps to confirm the desired behavior:

  1. Go to 'kits/selectable_card/rails'
  2. Scroll down to 'Selected, with icon' -- Border and check circle colors should be changed.
  3. Scroll down to 'Block and With Options' -- All variants should now support dark mode

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.

@Lsimmons98 Lsimmons98 added the milano 20 MAX - Deploy this PR to a review environment via Milano label Nov 26, 2024
@Lsimmons98 Lsimmons98 requested a review from a team as a code owner November 26, 2024 19:27
@Lsimmons98 Lsimmons98 added improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) minor Semver Target labels Nov 26, 2024
nidaqg
nidaqg previously approved these changes Nov 27, 2024
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Nov 27, 2024
@Lsimmons98 Lsimmons98 changed the title [PLAY-1667] Dark Mode Audit - Selectable Card [PLAY-1668] Dark Mode Audit - Selectable Card Nov 27, 2024
@Lsimmons98 Lsimmons98 added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants