Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Splunk URL for logging #3665

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

c-gerke
Copy link
Contributor

@c-gerke c-gerke commented Sep 6, 2024

What does this PR do? A clear and concise description with your runway ticket url.
Copy the new URL from the original idea in Tempo PR #3691

Screenshots: Screenshots to visualize your addition/change

How to test? Steps to confirm the desired behavior:

  1. Go to a Milano environment
  2. Click on "More" in the top right, and then "logs"
  3. Logs won't appear because the URL needs to change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

Copy the new URL from the original idea in Tempo PR #3691
Copy the new URL from the original idea in Tempo PR #3691
@c-gerke c-gerke requested review from a team as code owners September 6, 2024 15:47
@c-gerke c-gerke added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) labels Sep 6, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Sep 9, 2024
Merged via the queue into master with commit 682330f Sep 9, 2024
5 checks passed
@jasperfurniss jasperfurniss deleted the FVR/update-milano-logging-url branch September 9, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants