Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1421] Add all target options to the Hashtag and Home Address Street Kits #3650

Merged

Conversation

skduncan
Copy link
Contributor

@skduncan skduncan commented Sep 4, 2024

What does this PR do? A clear and concise description with your runway ticket url.
https://runway.powerhrg.com/backlog_items/PLAY-1421

Adding 'Target' prop to the Hashtag and Home Address Street kits. Also updates examples, docs, and tests where appropriate for these changes.

Screenshots: Screenshots to visualize your addition/change

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@skduncan skduncan added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Sep 4, 2024
@skduncan skduncan requested review from a team as code owners September 4, 2024 13:33
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-1421addtargetoptionhashtagandhomekits

@nidaqg nidaqg added the Product Approved pending technical review, OK to merge to master label Sep 6, 2024
jasperfurniss
jasperfurniss previously approved these changes Sep 6, 2024
@jasperfurniss jasperfurniss added Code Approved Approved by a Playbook Admin and removed Needs Review labels Sep 6, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Sep 6, 2024
Merged via the queue into master with commit e7f0645 Sep 6, 2024
5 checks passed
@jasperfurniss jasperfurniss deleted the PLAY-1421_add_target_option_hashtag_and_home_kits branch September 6, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants