Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1458] Fix kebab logic #3649

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

markdoeswork
Copy link
Contributor

@markdoeswork markdoeswork commented Sep 3, 2024

What does this PR do? A clear and concise description with your runway ticket url.
Runway https://runway.powerhrg.com/backlog_items/PLAY-1458

This issue was discovered when trying to remove font awesome from playbook website
#3547

The icons like grid-2 were not being converted correctly. You can find grid 2 on the main nav on the left for the "Components" nav item

check it out here
https://pr3649.playbook.beta.hq.powerapp.cloud/

@markdoeswork markdoeswork added the milano 20 MAX - Deploy this PR to a review environment via Milano label Sep 3, 2024
@markdoeswork markdoeswork self-assigned this Sep 3, 2024
@markdoeswork markdoeswork marked this pull request as ready for review September 4, 2024 13:48
@markdoeswork markdoeswork requested review from a team as code owners September 4, 2024 13:48
@markdoeswork markdoeswork added enhancement New Features, Props, & Variants (USED IN CHANGELOG) and removed enhancement New Features, Props, & Variants (USED IN CHANGELOG) labels Sep 5, 2024
@jasperfurniss jasperfurniss added Product Approved pending technical review, OK to merge to master Code Approved Approved by a Playbook Admin labels Sep 6, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Sep 6, 2024
Merged via the queue into master with commit 08bea84 Sep 6, 2024
9 checks passed
@jasperfurniss jasperfurniss deleted the play/1458_add_int_to_kebab_logic branch September 6, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants