[PLAY-1432] Playground Sanitization Security #3624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdoeswork
added
alpha
milano
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.2.0.pre.alpha.play1432playgroundsanitation3622 Your Alpha for NPM is 14.2.0-alpha.play1432playgroundsanitation3622 |
markdoeswork
removed
the
milano
markdoeswork
added
the
milano
jasperfurniss
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
Runway https://runway.powerhrg.com/backlog_items/PLAY-1432
Anyone was able to input whatever erb into the playground. This was bad because people could do shell scrips and other stuff by submitting something like this
<%= system(“pwd”) %>The plan is to evaluate the ERB code coming in and if it has a method that isn’t on the white list then the request is not processed
These methods have to be on the white list because the Parser parses ruby and theses methods are needed to “run” erb
More details about my thoughts here https://huddle.powerapp.cloud/v2/projects/647/artifacts/6881