[PBNTR-373] (Enable Kits Instead of Text for Radio label) #3612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickamantia
added
milano
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.1.0.pre.alpha.pbntr373enablekitsforradio3593 Your Alpha for NPM is 14.1.0-alpha.pbntr373enablekitsforradio3593 |
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.1.0.pre.alpha.pbntr373enablekitsforradio3595 Your Alpha for NPM is 14.1.0-alpha.pbntr373enablekitsforradio3595 |
nidaqg
reviewed
Aug 27, 2024
ElisaShapiro
previously approved these changes
Aug 29, 2024
playbook/app/pb_kits/playbook/pb_radio/docs/_radio_children.jsx
Outdated
Show resolved
Hide resolved
carloslimasd
previously approved these changes
Aug 30, 2024
nickamantia
dismissed stale reviews from carloslimasd and ElisaShapiro
via
3adc0a3
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.2.1.pre.alpha.pbntr373enablekitsforradio3665 Your Alpha for NPM is 14.2.1-alpha.pbntr373enablekitsforradio3665 |
carloslimasd
approved these changes
Sep 6, 2024
ElisaShapiro
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
😎 nice - if this gets merged in soon I will pull in these changes and center the doc examples within PBNTR-479 like the initial plan.
nidaqg
approved these changes
Sep 6, 2024
nidaqg
added
Product Approved
jasperfurniss
changed the title
nidaqg
added a commit
that referenced
this pull request
Sep 11, 2024
…)" This reverts commit 7ea0e37.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBNTR-373
This PR adds the ability to have a child wrapped around the
<Radio>kit. When this child is clicked. it will check off the radio button!How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.