Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond with echo messages #27

Merged
merged 7 commits into from
Oct 9, 2024
Merged

Respond with echo messages #27

merged 7 commits into from
Oct 9, 2024

Conversation

pool2win
Copy link
Owner

@pool2win pool2win commented Oct 9, 2024

No description provided.

Echos are now properly sent using reliable sending handles.

Messages are now either Unicast or Broadcast. Each message type choses
between the two types.

Messages are then responded differently based on Unicast or Broadcast
types.
Add mocks for echo broadcast handle and use them in tests
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.05785% with 82 lines in your changes missing coverage. Please review.

Project coverage is 87.68%. Comparing base (123110f) to head (4b1b3b2).

Files with missing lines Patch % Lines
src/node.rs 63.25% 61 Missing ⚠️
src/node/protocol.rs 76.59% 11 Missing ⚠️
src/node/echo_broadcast/mod.rs 92.15% 8 Missing ⚠️
src/node/protocol/round_one_package.rs 97.22% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   85.37%   87.68%   +2.31%     
==========================================
  Files          18       19       +1     
  Lines        1990     2266     +276     
==========================================
+ Hits         1699     1987     +288     
+ Misses        291      279      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pool2win pool2win merged commit 0d119e1 into main Oct 9, 2024
9 of 10 checks passed
@pool2win pool2win deleted the respond-with-echo-messages branch October 9, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants