Only scheduler 0 can initiate shutdown #4543
Merged
+36
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prior to this commit, every scheduler thread tried to initiate the shutdown CNF/ACK process if it was unable to `steal` from another scheduler thread even through in practice only scheduler 0 could ever initiate shutdown since it is the only one that receives ACK/BLOCK/SUSPEND messages and has enough information. This commit changes things so that it is explicit that only scheduler 0 initiates the shutdown CNF/ACK process.
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prior to this commit, every scheduler thread tried to initiate the shutdown CNF/ACK process if it was unable to
stealfrom another scheduler thread even through in practice only scheduler 0 could ever initiate shutdown since it is the only one that receives ACK/BLOCK/SUSPEND messages and has enough information.This commit changes things so that it is explicit that only scheduler 0 initiates the shutdown CNF/ACK process.