Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple sanitizers to be enabled at the same time #4538

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

dipinhora
Copy link
Contributor

Allow multiple sanitizers to be enabled at the same time

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Nov 22, 2024
@SeanTAllen
Copy link
Member

Is there anything we can do as a simple test to make sure this doesn't get broken in the future?

@dipinhora
Copy link
Contributor Author

we can add a CI build matrix variation that enables multiple sanitizers (asan/ubsan probably).. it's something to work towards where we can have both enabled as a CI matrix option with them configured to fail if anything is flagged as a way to maintain C code hygiene.. unfortunately, it's not really feasible as of right now due to a large amount of preexisting issues that would cause all such builds to fail...

not sure if it is possible to add in a test for CMake logic otherwise..

@SeanTAllen SeanTAllen merged commit 0533298 into ponylang:main Nov 22, 2024
23 checks passed
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants