Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop pushing new images to DockerHub #4473

Merged
merged 1 commit into from
Dec 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .ci-dockerfiles/stdlib-builder/build-and-push.bash
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ MIA="${MATERIAL_INSIDERS_ACCESS}"
set -o nounset

#
# *** You should already be logged in to DockerHub when you run this ***
# *** You should already be logged in to GitHub Container Registry when you run
# this ***
#

DOCKERFILE_DIR="$(dirname "$0")"
Expand Down
9 changes: 2 additions & 7 deletions .dockerfiles/latest/x86-64-pc-windows-msvc/build-and-push.ps1
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
# You should already be logged in to DockerHub and GitHub Container Registry
# when you run this.
# You should already be logged in to GitHub Container Registry when you run
# this.
$ErrorActionPreference = 'Stop'

$dockerfileDir = Split-Path $script:MyInvocation.MyCommand.Path

## DockerHub

docker build --pull -t "ponylang/ponyc:windows" $dockerfileDir
docker push "ponylang/ponyc:windows"

## GitHub Container Registry

docker build --pull -t "ghcr.io/ponylang/ponyc:windows" $dockerfileDir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,12 @@ set -o errexit
set -o nounset

#
# *** You should already be logged in to DockerHub
# and GitHub Container Registery when you run this ***
# *** You should already be logged in to GitHub Container Registry when you run
# this ***
#

DOCKERFILE_DIR="$(dirname "$0")"

## DockerHub

docker build --pull -t "ponylang/ponyc:latest" "${DOCKERFILE_DIR}"
docker push "ponylang/ponyc:latest"

## GitHub Container Registry

docker build --pull -t "ghcr.io/ponylang/ponyc:latest" "${DOCKERFILE_DIR}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,12 @@ set -o errexit
set -o nounset

#
# *** You should already be logged in to DockerHub
# and GitHub Container Registery when you run this ***
# *** You should already be logged in to GitHub Container Registry when you run
# this ***
#

DOCKERFILE_DIR="$(dirname "$0")"

## DockerHub

docker build --pull -t "ponylang/ponyc:alpine" "${DOCKERFILE_DIR}"
docker push "ponylang/ponyc:alpine"

## GitHub Container Registry

docker build --pull -t "ghcr.io/ponylang/ponyc:alpine" "${DOCKERFILE_DIR}"
Expand Down
14 changes: 2 additions & 12 deletions .dockerfiles/release/x86-64-pc-windows-msvc/build-and-push.ps1
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# You should already be logged in to DockerHub and GitHub Container Registry
# when you run this.
# You should already be logged in to GitHub Container Registry when you run
# this.
$ErrorActionPreference = 'Stop'

if ([string]::IsNullOrWhitespace($env:VERSION))
Expand All @@ -14,16 +14,6 @@ if ([string]::IsNullOrWhitespace($env:GITHUB_REPOSITORY))

$dockerfileDir = Split-Path $script:MyInvocation.MyCommand.Path

## DockerHub

$dockerTag = $env:GITHUB_REPOSITORY + ':' + $env:VERSION + '-windows'
docker build --pull -t "$dockerTag" "$dockerfileDir"
docker push "$dockerTag"

$dockerTag = $env:GITHUB_REPOSITORY + ':release-windows'
docker build --pull -t "$dockerTag" "$dockerfileDir"
docker push "$dockerTag"

## GitHub Container Registry

$dockerTag = "ghcr.io/" + $env:GITHUB_REPOSITORY + ':' + $env:VERSION + '-windows'
Expand Down
15 changes: 2 additions & 13 deletions .dockerfiles/release/x86-64-unknown-linux-gnu/build-and-push.bash
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/bin/bash

# ** You should already be logged in to DockerHub and GHCR when you run this **
# ** You should already be logged in to GitHub Container Registry when you run
# this **
#
# Builds docker release images with two tags:
#
Expand Down Expand Up @@ -41,18 +42,6 @@ set -o nounset

DOCKERFILE_DIR="$(dirname "$0")"

## DockerHub

# Build and push :VERSION tag e.g. ponylang/ponyup:0.32.1
DOCKER_TAG="${GITHUB_REPOSITORY}:${VERSION}"
docker build --pull -t "${DOCKER_TAG}" "${DOCKERFILE_DIR}"
docker push "${DOCKER_TAG}"

# Build and push "release" tag e.g. ponylang/ponyup:release
DOCKER_TAG="${GITHUB_REPOSITORY}:release"
docker build --pull -t "${DOCKER_TAG}" "${DOCKERFILE_DIR}"
docker push "${DOCKER_TAG}"

## GitHub Container Registry

# Build and push :VERSION tag e.g. ponylang/ponyup:0.32.1
Expand Down
15 changes: 2 additions & 13 deletions .dockerfiles/release/x86-64-unknown-linux-musl/build-and-push.bash
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/bin/bash

# ** You should already be logged in to DockerHub and GHCR when you run this **
# ** You should already be logged in to GitHub Container Registry when you run
# this **
#
# Builds docker release images with two tags:
#
Expand Down Expand Up @@ -41,18 +42,6 @@ set -o nounset

DOCKERFILE_DIR="$(dirname "$0")"

## DockerHub

# Build and push :VERSION tag e.g. ponylang/ponyup:0.32.1-alpine
DOCKER_TAG="${GITHUB_REPOSITORY}:${VERSION}-alpine"
docker build --pull -t "${DOCKER_TAG}" "${DOCKERFILE_DIR}"
docker push "${DOCKER_TAG}"

# Build and push "release" tag e.g. ponylang/ponyup:release-alpine
DOCKER_TAG="${GITHUB_REPOSITORY}:release-alpine"
docker build --pull -t "${DOCKER_TAG}" "${DOCKERFILE_DIR}"
docker push "${DOCKER_TAG}"

## GitHub Container Registry

# Build and push :VERSION tag e.g. ponylang/ponyup:0.32.1-alpine
Expand Down
30 changes: 0 additions & 30 deletions .github/workflows/cloudsmith-package-sychronised.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Login to DockerHub
run: docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD"
env:
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
- name: Login to GitHub Container Registry
# v2.2.0
uses: docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc
Expand Down Expand Up @@ -56,11 +51,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Login to DockerHub
run: docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD"
env:
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
- name: Login to GitHub Container Registry
# v2.2.0
uses: docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc
Expand Down Expand Up @@ -91,11 +81,6 @@ jobs:
runs-on: windows-2022
steps:
- uses: actions/checkout@v3
- name: Login to DockerHub
run: "docker login -u $env:DOCKER_USERNAME -p $env:DOCKER_PASSWORD"
env:
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
- name: Login to GitHub Container Registry
# v2.2.0
uses: docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc
Expand Down Expand Up @@ -126,11 +111,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Login to DockerHub
run: docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD"
env:
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
- name: Login to GitHub Container Registry
# v2.2.0
uses: docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc
Expand All @@ -152,11 +132,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Login to DockerHub
run: docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD"
env:
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
- name: Login to GitHub Container Registry
# v2.2.0
uses: docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc
Expand All @@ -178,11 +153,6 @@ jobs:
runs-on: windows-2022
steps:
- uses: actions/checkout@v3
- name: Login to DockerHub
run: "docker login -u $env:DOCKER_USERNAME -p $env:DOCKER_PASSWORD"
env:
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
- name: Login to GitHub Container Registry
# v2.2.0
uses: docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc
Expand Down
6 changes: 1 addition & 5 deletions RELEASE_PROCESS.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ We rely on Cloudsmith and GitHub Actions as part of our release process. Both ne
* [Cloudsmith](https://status.cloudsmith.io/)
* [GitHub](https://www.githubstatus.com/)

We are in the process of migrating off of DockerHub, while that migration is going on, we are also relying on it, so you need to make sure it is functional before doing a release.

* [DockerHub](https://status.docker.com/)

## Releasing

Please note that this document was written with the assumption that you are using a clone of the `ponyc` repo. You have to be using a clone rather than a fork. It is advised that you do this by making a fresh clone of the `ponyc` repo from which you will release.
Expand Down Expand Up @@ -74,7 +70,7 @@ The images are built via GitHub action after Linux releases have been uploaded t

### Verify that the Pony Playground updated to the new version

Once the DockerHub images have been updated, the Pony playground should automatically update. You can check the version running by compiling a small Pony program and verifying that the version listed in the output matches the newly released Pony version.
Once the images have been updated, the Pony playground should automatically update. You can check the version running by compiling a small Pony program and verifying that the version listed in the output matches the newly released Pony version.

If the versions are different, you'll need to log in to the playground server as root and run `bash update-playground.bash`.

Expand Down
Loading