-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: set compat_level when calling to_arrow #85
Conversation
I'm still wondering how to ensure forward compatibility with As for backward compatibility, we can simply retry with |
I've made this PR work with it. In |
@@ -13,3 +13,10 @@ polars-core = { version = "0.41.0", default-features = false } | |||
polars-ffi = { version = "0.41.0", default-features = false } | |||
polars-plan = { version = "0.41.0", default-feautres = false } | |||
polars-lazy = { version = "0.41.0", default-features = false } | |||
|
|||
[patch.crates-io] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we point this to the main branch until 0.42
is released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cargo only recognizes patches defined in the root project and not in dependencies. pyo3-polars
is meant to be a dependency of projects that use it. So unless they declare patches in their Cargo.toml
, patches are not in effect.
Patches declared here are only for testing. We can only wait for 0.42
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. 0.42 is planned in ca. 2 weeks.
This depends on pola-rs/polars#17371.
In my naive benchmark, with large string columns, it improves the speed to ~10x.