feat: additional error properties #11
Conversation
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 11 out of 17 changed files in this pull request and generated 1 suggestion.
Files not reviewed (6)
- package.json: Language not supported
- rust-toolchain: Language not supported
- rustfmt.toml: Evaluated as low risk
- .github/workflows/CI.yml: Evaluated as low risk
- Cargo.toml: Evaluated as low risk
- src/lib.rs: Evaluated as low risk
Co-authored-by: Copilot <[email protected]>
index.js
Outdated
There was a problem hiding this comment.
The old version of this file is moved to binding.js. The new index.js is a wrapper around binding.js.
binding.js
Outdated
There was a problem hiding this comment.
This file was index.js.
Why did Copilot see them as low risk is beyond me. |
| reflinkFileSync( | ||
| join(dir, 'file-does-not-exist.txt'), | ||
| join(dir, 'file1-copy.txt') | ||
| ); | ||
| }).toThrow(); |
There was a problem hiding this comment.
why not using await expect(...).rejects.toMatchObject({?
There was a problem hiding this comment.
I have replace all try catch block with expect().rejects (bcbbfaa).
|
I thought it was async. If it is sync, you can just use expect throws |
|
|
ok, then use try/catch instead, as it was before |
KSXGitHub
force-pushed
the
error-codes
branch
from
bcbbfaa
to
e34a6d3
Compare
|
Reverted. |
No description provided.