Create Rule_11-9.md #1372
Create Rule_11-9.md #1372
Conversation
KarenWGard
requested review from
JasonGlazer,
supriyagoel,
weilixu,
claperle and
JacksonJ-KC
docs/section11/Rule_11-9.md
Outdated
|
|
||
| **Rule Description:** "The baseline system must be sized according to Standard 90.1 2019, Section 7.4.1." | ||
|
|
||
| **Rule Assertion:** Applicable / not applicable |
There was a problem hiding this comment.
The outcomes for non mandatory rules need to be: UNDETERMINED/NOT_APPLICABLE
docs/section11/Rule_11-9.md
Outdated
|
|
||
| **Rule Assertion:** Applicable / not applicable | ||
|
|
||
| **Appendix G Section Reference:** Table G3.1 #11, proposed column, a & b |
There was a problem hiding this comment.
The reuirement is only in Table G3.1 #11, proposed column, a (not b)
docs/section11/Rule_11-9.md
Outdated
|
|
||
| **Appendix G Section Reference:** Table G3.1 #11, proposed column, a & b | ||
|
|
||
| **Evaluation Context:** B-RMD each SHW type |
There was a problem hiding this comment.
Recommend avoiding the use of SHW type language as the meaning is not fully clear
docs/section11/Rule_11-9.md
Outdated
| **Evaluation Context:** B-RMD each SHW type | ||
| **Data Lookup:** | ||
| **Function Call:** | ||
| - **get_SHW_types_and_spaces** |
There was a problem hiding this comment.
I think this needs to be updated with the lastest function name
docs/section11/Rule_11-9.md
Outdated
| - **get_SHW_types_and_spaces** | ||
|
|
||
| **Applicability Checks:** | ||
| - check that the SHW type in the B_RMD has SHW loads |
There was a problem hiding this comment.
Same comment regardign language and clarity as above. Please apply to the whole RDS.
docs/section11/Rule_11-9.md
Outdated
| - look at each SHW space type: `for shw_space_type in shw_and_spaces_dict:` | ||
| - look at each space: `for space_id in shw_and_spaces_dict[shw_space_type]:` | ||
| - get the space using get_component_by_id: `space = get_component_by_id(U_RMD, space_id)` | ||
| - look for the ServiceWaterHeatingUse in the space. If even one space has a ServiceWaterHeatingUse, this rule is applicable: `if len(u.space.service_water_heating_uses) > 0: APPLICABLE` |
There was a problem hiding this comment.
Need to have a rule assertion. See example of a non mandatory RDS here . I do not believe application is one of the RCT outcomes. The outcome would be UNDETERMINED with a message for the reviewer about what needs to be checked.
| @@ -0,0 +1,35 @@ | |||
| # Service_Water_Heating - Rule 11-9 | |||
| **Schema Version:** 0.0.38 | |||
There was a problem hiding this comment.
most recent version is 0.0.37
docs/section11/Rule_11-9.md
Outdated
| - check that the SHW BAT in the B_RMD has SHW loads | ||
|
|
||
| ## Applicability Checks: | ||
| - only projects with SHW for the SHW space BAT in the baseline model are applicable |
There was a problem hiding this comment.
I don't understand this line, "projects with SHW for the SHW space type"
docs/section11/Rule_11-9.md
Outdated
| ## Applicability Checks: | ||
| - only projects with SHW for the SHW space BAT in the baseline model are applicable | ||
|
|
||
| - use the function get_spaces_associated_with_each_SWH_bat to get a list of spaces for each SHW BAT: `shw_and_spaces_dict = get_spaces_associated_with_each_SWH_bat(U_RMD)` |
There was a problem hiding this comment.
My opinion -
use the function get_spaces_associated_with_each_SWH_bat to get a list of spaces for each SHW BAT:
is easier to follow. let the pseudo code part be the reference for calling the function name
docs/section11/Rule_11-9.md
Outdated
| - create a boolean rule_is_applicable and set it to false: `rule_is_applicable = false` | ||
| - look at each space: `for space_id in shw_and_spaces_dict[swh_bat]:` | ||
| - get the space using get_component_by_id: `space = get_component_by_id(U_RMD, space_id)` | ||
| - look for the ServiceWaterHeatingUse in the space. If even one space has a ServiceWaterHeatingUse, this rule is applicable: `if len(u.space.service_water_heating_uses) > 0: rule_is_applicable = true` |
There was a problem hiding this comment.
if len( u. space.service_water_heating_uses) > 0: rule_is_applicable = true
docs/section11/Rule_11-9.md
Outdated
| - only projects with SHW use for the SHW space BAT in the baseline model are applicable | ||
|
|
||
| - use the function get_SWH_bats_and_SWH_use to get a list of SWH uses for each BAT: `shw_bat_uses_dict = get_SWH_bats_and_SWH_use(U_RMD)` | ||
| - look at each SHW BAT: `for swh_bat in shw_bat_uses_dict:` |
There was a problem hiding this comment.
I think this shudl be .keys()
| - if even one use is greater than zero, go to rule assertion: `if swh_use.use > 0: GO TO RULE ASSERTION` | ||
|
|
||
| ## Rule Assertion: | ||
| - if the boolean rule_is_applicable is equal to true, the rule is applicable, return UNDETERMINED and a note letting the reviewer know what to check: `if rule_is_applicable: UNDETERMINED raise_message: "Check that the baseline Service Water Heating System for Building Area Type " + swh_bat + " is sized according to ASHRAE Standard 90.1 2019, Section 7.4.1."` |
There was a problem hiding this comment.
this rule_is_applicable boolean true or false does not appear to be set anywhere
There was a problem hiding this comment.
updated to set it explicitly
No description provided.