Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ipopt & CoinHSL #137

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Upgrade Ipopt & CoinHSL #137

wants to merge 2 commits into from

Conversation

jaelynlitz
Copy link
Contributor

Merge request type

  • New feature
  • Resolves bug
  • Documentation
  • Other

Relates to

  • OPFLOW
  • SOPFLOW
  • SCOPFLOW
  • TCOPFLOW
  • CMake build system
  • Spack configuration
  • Manual
  • Web docs
  • Other

This MR updates

  • Header files
  • Source code
  • CMake build system
  • Spack configuration
  • Web docs
  • Manual
  • Other

Summary

  • Allow IPOPT to upgrade past v3.12.10
  • Test with CoinHSL v2023.11.17

@cameronrutherford
Copy link
Contributor

@jaelynlitz are you able to take a look at why coinhsl, ipopt and suite-sparse are failing to build? I am happy to take this off your plate if you're unable to get to it

require: '@3.12.10~metis+coinhsl~mumps'
require: '~metis+coinhsl~mumps'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you need to build coinhsl with Metis support. Otherwise the linear solver and by extension Ipopt will have diminished performance.

CC @nychiang @cameronrutherford

@@ -24,9 +24,9 @@ spack:
magma:
require: '@2.6.2'
coinhsl:
require: '@2019.05.21'
require: '@2023.11.17'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
require: '@2023.11.17'
require: '@2023.11.17+metis'

@pelesh per your suggestion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is it sufficient just to build Ipopt with metis... Or do we need both? Should the spack package force coinhsl+metis if ipopt+metis for these later versions?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ipopt does not depend on Metis, only HSL does. I am not sure what ipopt+metis is supposed to do tbh.

Forcing coinhsl+metis is the right thing to do imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants