Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++17 Standard #55

Open
jaelynlitz opened this issue Oct 21, 2023 · 1 comment · May be fixed by #57
Open

C++17 Standard #55

jaelynlitz opened this issue Oct 21, 2023 · 1 comment · May be fixed by #57
Milestone

Comments

@jaelynlitz
Copy link
Contributor

jaelynlitz commented Oct 21, 2023

In pursuit of #322 this MR is in progress !463 - in order to use std::filesystem, the C++ standard must be at least 17 with a gcc version of at least 9. These upgrades went smoothly on Deception, as gcc10.2.0 was already used, but Newell is causing problems.
https://community.intel.com/t5/Intel-DevCloud/dpcpp-using-C-17-header/m-p/1212280
Now, newell is with gcc10.2.0, c++17 standard - we still get an error with std::fs
see file fs.txt fs.txt
the -lstdc++fs -std=c++17 flags are being correctly passed to gcc and mpic++, but nvcc is using the c++11 standard - this may be our culprit
I tried adding set(CUDA_NVCC_FLAGS "-std=c++17") to the main CMakeLists.txt but that did not seem to pass on the flag correctly.
Commenting out the std::fs lines in the source code with or without the NVCC flag line added causes Umpire to error.
see file nvcc17.txt nvcc17.txt
I fear that umpire6.0.0 may not allow us to use the c++17 standard. #54 #56
!463 !462 (closed)

https://gitlab.pnnl.gov/exasgd/frameworks/exago/-/issues/447
https://gitlab.pnnl.gov/exasgd/frameworks/exago/-/merge_requests/463

@jaelynlitz
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants