Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::filesystem for path-like objects #56

Open
jaelynlitz opened this issue Oct 21, 2023 · 1 comment
Open

Use std::filesystem for path-like objects #56

jaelynlitz opened this issue Oct 21, 2023 · 1 comment
Milestone

Comments

@jaelynlitz
Copy link
Contributor

Currently we use char[]s of PETSC_MAX_PATH_LEN with a suite of hand-rolled tools in utils.h for dealing with paths and determining existence of files. This functionality is in std::filesystem, and in a mostly-compliant C++11-compatible header-only library here.

If we move our C++ standard up to 17 (#55), this functionality is present in std::filesystem which is easier to include as opposed to the third party lib that is linked. What are thoughts on changing the standard?

From @pelesh

Updating to C++17 is preferred to keeping an extra dependency imho. Probably more testing is needed than just building a couple of different ExaGO configurations. I am not sure either is needed, though. All we need here are some very standard string manipulations.

@jaelynlitz
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants