Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by Seen Type / Configurable PVP Ranking Method / AR eligible flag / Tweaked raid timers / + More #607

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

bradders2000
Copy link

Added: Ability to filter the map by seen type - all, wild, nearby (pokestop), nearby (other - aka cell) etc.
Added: Ability to select the PVP ranking method.
Added: AR flag to gyms/pokestops.
Added: Optional shadow to rank 1 PVP pokemon.
Added: Ability to temporarily hide specific pokemon forms
Added: Ability to only show gyms that haven't been scanned in the past X hours
Added: Display multiple quest rewards on pokestop label
Changed: Raid timers to look more like the in-game ones.

bradders added 18 commits November 15, 2021 21:20
Add AR tag to gym marker icons.
Add support for configuring which RDM PvP ranking method gets used when filtering and displaying pokemon.
Change the egg/raid timers so they look more like the in-game ones.
Add AR tag to gym marker icons.
Add support for configuring which RDM PvP ranking method gets used when filtering and displaying pokemon.
Change the egg/raid timers so they look more like the in-game ones.
Add AR tag to gym marker icons.
Add support for configuring which RDM PvP ranking method gets used when filtering and displaying pokemon.
Change the egg/raid timers so they look more like the in-game ones.
Add AR tag to gym marker icons.
Add support for configuring which RDM PvP ranking method gets used when filtering and displaying pokemon.
Change the egg/raid timers so they look more like the in-game ones.
Adds the ability to filter map display by spawn/seen type - set 'noSpawnType=false' in access config for groups you wish to have access to this, it's hidden by default.
Added: Ability to temporarily hide specific pokemon forms
Added: Ability to only show gyms that haven't been scanned in the past X hours
Added: Display multiple quest rewards on pokestop label
@bradders2000
Copy link
Author

Just had a thought... quest_rewards doesn't appear to exist in the MAD world, so my tweak to display multiple rewards on the pokestop label will actually break stuff there.
Maybe someone familiar with/using MAD can suggest a fix?

@whitewillem
Copy link
Collaborator

Put anything you add in rdm lib as well for mad but set it to null. Then check if not null in js

@bradders2000
Copy link
Author

Put anything you add in rdm lib as well for mad but set it to null. Then check if not null in js

Thanks, yeah, that's basically what I did in commit 8365b99 - checked if undefined / null and used old code if it was, or new code (showing multiple rewards) if it wasn't.

@TiMXL73
Copy link
Collaborator

TiMXL73 commented Feb 25, 2022

In case you didn't know, mad has the is_ar_scan_eligible field for both the gyms and pokestop table (tinyint, 0=NoAR and 1=WithAR). Might as well use them instead of defaulting to 0.

@bradders2000
Copy link
Author

In case you didn't know, mad has the is_ar_scan_eligible field for both the gyms and pokestop table (tinyint, 0=NoAR and 1=WithAR). Might as well use them instead of defaulting to 0.

Thanks. I know absolutely nothing about mad and its database/table structure. I will tweak accordingly.

bradders added 2 commits February 25, 2022 15:58
Added: Quest encounter reward text on pokestop label now includes pokemon form (if any).
Fixed: Use is_ar_scan_eligible field from MAD pokestop table rather than forcing to 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants