Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rails Depedendency #7

Merged
merged 3 commits into from
May 28, 2015
Merged

Remove Rails Depedendency #7

merged 3 commits into from
May 28, 2015

Conversation

plribeiro3000
Copy link
Owner

No description provided.

require 'readline'
require 'awesome_print'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

plribeiro3000 added a commit that referenced this pull request May 28, 2015
@plribeiro3000 plribeiro3000 merged commit bc76bc8 into master May 28, 2015
@plribeiro3000 plribeiro3000 deleted the remove-rails-dependency branch May 28, 2015 02:04
@skull-squadron
Copy link

That defies common sense of having a batteries-included pry bundle.

No problem, anyone wanting a sane, easy-to-configure, "Just Works" ™️ pry bundle for either Ruby or Rails or standalone can simply install spirit_hands.

gem install spirit_hands or gem 'spirit_hands'

@plribeiro3000
Copy link
Owner Author

Well, i can see your point but i believe its too heavy to depend on railties and activesupport when all you want is pry with some candies. A simple dependency tree will attend both cases where the more complex ones just need to add an extra gem to the list IMHO. =)

This PR was to fix nixme/jazz_hands#8. My real intention was that the original lib didn't die.

If you want to maintain this lib, then go ahead. I will keep maintaining this as a simpler option for non rails projects in the meanwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants