Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neyberson/browser protocol #8

Merged
merged 74 commits into from
Aug 19, 2024
Merged

Neyberson/browser protocol #8

merged 74 commits into from
Aug 19, 2024

Conversation

neyberson
Copy link
Collaborator

No description provided.

@neyberson
Rename Connection class to Protocol
c2da7ed
@neyberson
Change connection.py to protocol.py
a1227a1
@neyberson
Create connection_protocol attribute at Browser class
72550eb
@neyberson
Create browser_pipe attribute at Protocol class
fba9434
@neyberson
Create send_command() at Browser class
637706e
@neyberson
Fixbug to create Protocol object at Browser class
761ce8f
@neyberson
Change Connection to Protocol and variable names at app_devtools.py
2749d0d
@neyberson
Create Tab class and add_session method
84facea
@neyberson
Creaste list_sessions(), close_session() and send_command() and tab.py
abc9eb5
@neyberson
Change the Session object to Tab object at Protocol class
794c4f3
@neyberson
Change create_tab() to use Tab instance at Protocol class
5af96e9
@neyberson
Update list_tabs() to use Tab instances at Protocol class
37d2fd0
@neyberson
Update close_tabs() to use Tab instances at Protocol class
3595de3
@neyberson
Update send_command() to use Tab instances at Protocol class
5fc6e8e
@neyberson
Format code at protocol.py
7d5ba61
@neyberson
Add Tab to __init__.py
fb375ac
@neyberson
Fixbug at list_tabs() from Protocol class
c330873
@neyberson
Format code at tab.py
49b8140
@neyberson
Create id parameter at Tab class
35f4ac9
@neyberson
Create list_tab_id list and logic to use id from Tab at Protocol
6d4b6f4
@neyberson
Update create_tab() and close_tab() to use id at Protocol class
a342a6f
@neyberson
Update list_tabs() to use id from Tab at Protocol class
4097de5
ayjayt
ayjayt requested changes Aug 13, 2024
View reviewed changes
devtools/__init__.py Outdated Show resolved Hide resolved
devtools/protocol.py Outdated Show resolved Hide resolved
devtools/protocol.py Outdated Show resolved Hide resolved
devtools/protocol.py Outdated Show resolved Hide resolved
devtools/protocol.py Show resolved Hide resolved
ayjayt
ayjayt requested changes Aug 14, 2024
View reviewed changes
devtools/protocol.py Outdated Show resolved Hide resolved
devtools/protocol.py Outdated Show resolved Hide resolved
devtools/protocol.py Outdated Show resolved Hide resolved
@neyberson
Delete _id_zero attribute at Protocol
99e4754
@neyberson
Change session_id default value attribute with uuid at Session
0b85eed
@neyberson
Delete close_tab() at Session
ca4bd39
@neyberson
Delete use of uuid at add_session() from Tab
863ff69
@neyberson
Delete useless str() at list_tabs() from Protocol
955cb4b
@neyberson
Change id to target_id at create_tab() from Protocol
01c5f20
@neyberson
Update app_devtools.py using Browser
98339ef
@neyberson
Delete self at send_command() from Protocol
7207800
@neyberson
Add b at encoded_message to fixbug at write_json()
0e8ea57
@neyberson
Update app.py for the devtools update
32fc384
@neyberson
Add headless to init from Browser
2650b42
@neyberson
Add headless from Browser at chrome_wrapper.py
db55dd8
@neyberson
Format code at chrome_wrapper.py
20284b6
@neyberson
Add headless=False to Browser at app.py
61ac56e
@neyberson
Format code at app.py
a06cced
@neyberson
Modify parameters and add conditionals at write_jsons()
e30ac01
@neyberson
Improve send_command() using write_jsons() at Session
cc0a034
@neyberson
Delete 's' at write_json() from send_command()
83393b5
@neyberson
Change connection_protocol attribute to protocol at Browser
f621d82
@neyberson
Change CLI_FLAG to HEADLESS and simplify at Browser
2e5dbab
@neyberson
Simplify conditionals to append --headless at chrome_wrapper.py
2dc58d8
@neyberson
Change browser_pipe attribute to pipe at Protocol
91a59a6
@neyberson
Improve close_tab() with conditionals at Protocol
905ce16
@neyberson
Use session_id as key at add_session() from Tab
511a9f4
@neyberson
Improve close_session() with conditionals at Tab
00b9490
@neyberson
Update app.py for update at devtools
20d08d7
@ayjayt
Copy link
Collaborator

ayjayt commented Aug 19, 2024

Aprobabdo pero con asuntos

@ayjayt ayjayt merged commit 17c7721 into main Aug 19, 2024
1 check passed
@ayjayt ayjayt deleted the neyberson/browser_protocol branch August 19, 2024 17:49
ayjayt added a commit that referenced this pull request Oct 17, 2024
@ayjayt
Merge pull request #8 from geopozo/neyberson/user_warning
b359c05 
Neyberson/user warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayjayt ayjayt ayjayt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neyberson @ayjayt